Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(examples) Update Dockerfile #4382

Merged
merged 2 commits into from
Oct 29, 2024
Merged

fix(examples) Update Dockerfile #4382

merged 2 commits into from
Oct 29, 2024

Conversation

wwjang
Copy link
Contributor

@wwjang wwjang commented Oct 28, 2024

Issue

There is a typo in the code that installs 'flwr-datasets' in the Dockerfile, so the process cannot proceed.

Proposal

Fix the typo "flwr-datsets" to "flwr-datasets".

Checklist

  • [v] Implement proposed change
  • [v] Write tests
  • Update documentation
  • Make CI checks pass
  • Ping maintainers on Slack (channel #contributions)
    => No need

Fix a typo "flwr-datsets" to "flwr-datasets".
@jafermarq
Copy link
Contributor

jafermarq commented Oct 28, 2024

Thanks for the fix @wwjang !!

I wanted to mention that we are in the process of updating that example. You can see the progress here if you are curious: #4381 It uses the flwr as in main so we'll merge it once the next stable version of Flower is out (in ~2 weeks). One remaining TODO in that PR is to build a PyTorch wheel that works with a Jetson supporting Jetpack 5.x.

Would you like to help us on that front? If yes, please feel free to open a new issue/PR! 🙏

@jafermarq jafermarq added the part: examples Add or update a Flower example label Oct 28, 2024
@tanertopal tanertopal enabled auto-merge (squash) October 29, 2024 08:31
Copy link
Member

@tanertopal tanertopal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@tanertopal tanertopal merged commit 1631f90 into adap:main Oct 29, 2024
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
part: examples Add or update a Flower example
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants